Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS 45 support #63

Merged
merged 5 commits into from
Nov 6, 2023
Merged

GS 45 support #63

merged 5 commits into from
Nov 6, 2023

Conversation

muffinmad
Copy link
Owner

Solve #62

@muffinmad muffinmad mentioned this pull request Nov 5, 2023
@muffinmad muffinmad merged commit 220a4d7 into master Nov 6, 2023
@muffinmad muffinmad deleted the gs45 branch November 6, 2023 18:53
@greatquux
Copy link

did you happen to submit to e.g.o as the version compatible with 45? still seeing the old one there.

@muffinmad
Copy link
Owner Author

The extension version 45 was rejected. The new version 46 was approved recently. I believe you can find it on e.g.o.

@greatquux
Copy link

looks like there is a comma that shouldn't be there on line 342. when i remove it, the extension loads and works
Nov 14 22:58:05 ossy gnome-shell[3049294]: JS ERROR: Extension pidgin@muffinmad: SyntaxError: expected property name, got ',' @ file:///home/mike/.local/share/gnome-shell/extensions/pidgin@muffinmad/extension.js:342:2

@muffinmad
Copy link
Owner Author

Thanks! I've uploaded the new version 47 to e.g.o. and deactivated version 46 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants