旧スタイルでもサブフォルダにファイルを移動 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
上記理由のため 元の todo-item.js.es6 の実装を todo-item/list-item.js.es6 に移動した
mugijiru
commented
Feb 27, 2021
| } | ||
| } | ||
| }); | ||
| window.TodoItem = Ember.Namespace.create(); |
There was a problem hiding this comment.
Description に書いた理由のため Namespace を用意している。
mugijiru
commented
Feb 27, 2021
| @@ -1,4 +1,4 @@ | |||
| TodoApp.TodoItemFormModalComponent = Ember.Component.extend({ | |||
| TodoItem.FormModalComponent = Ember.Component.extend({ | |||
There was a problem hiding this comment.
TodoApp ではなく
で用意した Namespace のコンポーネントとしている
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
旧スタイルだと
#13 にも書いたように DefaultResolver(GlobalsResolver) の parseName が使われる。
その場合は temoplate から
{{hoge/fuga}}と呼び出した際にはHoge という Namespace の FugaComponent を探しに行くという挙動になっている。
そのため、そういう Namespace を用意してあげて、
サブフォルダ内のファイルはそこに所属するように書いてあげる必要がある。
3階層以上になるとどうなるかはわからん……
https://github.com/emberjs/ember.js/blob/e2007b6ecb046fd06f6b43c381e8a1128914ad43/packages/%40ember/application/globals-resolver.js#L221
を見ると
{{hoge/fuga/piyo}}と書くとHoge.Fuga.PiyoComponent を探しに行きそうではある