Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clsx instead of classNames #126

Closed
lopezjurip opened this issue Jan 22, 2021 · 5 comments
Closed

Use clsx instead of classNames #126

lopezjurip opened this issue Jan 22, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@lopezjurip
Copy link

This module is a drop-in replacement but smaller and faster.
https://github.com/lukeed/clsx

@muhammadsammy muhammadsammy added enhancement New feature or request good first issue Good for newcomers labels Jan 22, 2021
@muhammadsammy
Copy link
Owner

This seems like a better alternative. Thanks for the suggestion!

@imrishabh18
Copy link
Contributor

@muhammadsammy Can I take up this issue? And what do I need to do. Remove the classnames dependency and add the clsx in place of that?

@muhammadsammy
Copy link
Owner

You 're welcome!
I believe this would do it + modifying the import statement in template string generation in the CLI too.

@imrishabh18
Copy link
Contributor

image

I have replaced the import statements and generated the file successfully, but while running yarn run-cli I don't know what should I give as path for the custom files types.

@muhammadsammy
Copy link
Owner

muhammadsammy commented May 6, 2021

This is optional for adding additional types if you have them in a file. just leave it empty
but the error is showing that tailwind.config.js can't be found. did you run npx tailwindcss init?

or just run yarn generate and it will update src/index.ts file automatically without any inputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants