Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor project workflow #14

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

MahmoudNasser01
Copy link
Collaborator

Developer checklist

  • Task is completed
  • The code has been run and tested
  • Wrote Tests

Reviewer checklist

  • Solution is right
  • The code has been run and tested

Assignee checklist

  • Solution is right
  • The code has been run and tested

Merge & Deploy notes

  • Updating Docs
  • Accept Changes

@gitguardian
Copy link

gitguardian bot commented Jul 8, 2023

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
7026943 Generic High Entropy Secret 8189cc8 test.py View secret
7026943 Generic High Entropy Secret e7e2201 test.py View secret
7032915 Generic High Entropy Secret 8189cc8 test.py View secret
7032915 Generic High Entropy Secret e7e2201 test.py View secret
7060520 Python Package Index Key 1557144 .github/workflows/publish.yml View secret
7060520 Python Package Index Key e7e2201 .github/workflows/publish.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@MahmoudNasser01
Copy link
Collaborator Author

I refactor some of the workflows
refactor requirements structure between local (dev environment) and prod (package environment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant