Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

device_type: add dimmable_light #89

Closed
wants to merge 1 commit into from
Closed

device_type: add dimmable_light #89

wants to merge 1 commit into from

Conversation

MitterdorferMathias
Copy link
Contributor

No description provided.

@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Dec 11, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@MitterdorferMathias MitterdorferMathias mentioned this pull request Dec 11, 2023
Closed
@MitterdorferMathias MitterdorferMathias changed the title device_type: add dimmable_light; default to UNKNOWN device_type: add dimmable_light Dec 11, 2023
@muhlba91
Copy link
Owner

thank you for your contribution again! 👍
i included the implementation and unit tests in the commit when adding the tests for the pergola data.
hence, closing this one.

@muhlba91 muhlba91 closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhlba91 muhlba91 Awaiting requested review from muhlba91 muhlba91 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MitterdorferMathias @muhlba91