-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api refactor #148
Api refactor #148
Conversation
@@ -86,7 +86,7 @@ module.exports = { | |||
'@material-ui/x-grid': path.resolve(__dirname, '../../../packages/grid/x-grid/src'), | |||
'@material-ui/x-license': path.resolve(__dirname, '../../../packages/license/src'), | |||
}, | |||
modules: [path.join(__dirname, '../../../'), 'node_modules'], | |||
// modules: [path.join(__dirname, '../../../'), 'node_modules'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To test the build locally? Don't forget to uncomment before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested and everything works fine without this.
I suspect it is the cause of your issue with the compilation of SB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah works great without.
// modules: [path.join(__dirname, '../../../'), 'node_modules'], |
Refactoring to remove
if (apiRef && apiRef.current) {