-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[blog] Post survey results 2020 #21555
Conversation
Details of bundle changes.Comparing: ebbf701...992d3b4 Details of page changes
|
Comparison analysis on the "How can we improve Material-UI for you?" with last year:
|
The prefix corresponds to the number of times the concern was mentioned. | ||
It’s sorted descending, with the most important concerns first: | ||
|
||
<style>th { text-align: left; background-color: #f2f2f2; }</style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This background colour makes text nearly impossible to read in dark mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need dark mode images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about we disable the dark mode for the blog pages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a bit annoying but probably the easiest way to fix this.
The prefix corresponds to the number of times the concern was mentioned. | ||
It’s sorted descending, with the most important concerns first: | ||
|
||
<style>th { text-align: left; background-color: #f2f2f2; }</style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about we disable the dark mode for the blog pages?
5e838e7
to
dc7a720
Compare
dc7a720
to
555eb4f
Compare
Co-authored-by: Matt <github@nospam.33m.co>
…al-ui into blog/2020-survey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better, thanks @mnajdova!
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tweak the wording in @mnajdova's suggestion.
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as table header background is sorted before merge I'm happy.
Should we maybe use stronger border on the bottom instead of background? @joshwooding @oliviertassinari what do you think? |
@mnajdova Sounds great. In the end, I believe we will get most of the readers on Medium, they won't see the style of the table (as far as I know, Medium will override it), so feel free to iterate as you see fit 👌. |
Blog post page - https://deploy-preview-21555--material-ui.netlify.app/blog/2020-developer-survey-results/