[blog] Post survey results 2020 #21555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: ebbf701...992d3b4 Details of page changes
|
Member
|
Comparison analysis on the "How can we improve Material-UI for you?" with last year: |
oliviertassinari
changed the title
joshwooding
reviewed
Jun 23, 2020
| The prefix corresponds to the number of times the concern was mentioned. | ||
| It’s sorted descending, with the most important concerns first: | ||
|
|
||
| <style>th { text-align: left; background-color: #f2f2f2; }</style> |
Collaborator
There was a problem hiding this comment.
This background colour makes text nearly impossible to read in dark mode.
Member
There was a problem hiding this comment.
We also need dark mode images.
Member
There was a problem hiding this comment.
What about we disable the dark mode for the blog pages?
Collaborator
There was a problem hiding this comment.
Might be a bit annoying but probably the easiest way to fix this.
| The prefix corresponds to the number of times the concern was mentioned. | ||
| It’s sorted descending, with the most important concerns first: | ||
|
|
||
| <style>th { text-align: left; background-color: #f2f2f2; }</style> |
Member
There was a problem hiding this comment.
What about we disable the dark mode for the blog pages?
mbrookes
reviewed
Jun 24, 2020
oliviertassinari
force-pushed
the
blog/2020-survey
branch
from
5e838e7 to
dc7a720
Compare
oliviertassinari
force-pushed
the
blog/2020-survey
branch
from
dc7a720 to
555eb4f
Compare
Co-authored-by: Matt <github@nospam.33m.co>
…al-ui into blog/2020-survey
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
oliviertassinari
approved these changes
Jun 27, 2020
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
joshwooding
approved these changes
Jun 27, 2020
joshwooding
approved these changes
Jun 27, 2020
Collaborator
joshwooding
left a comment
joshwooding
left a comment
There was a problem hiding this comment.
As long as table header background is sorted before merge I'm happy.
Member
Author
|
Should we maybe use stronger border on the bottom instead of background?
@joshwooding @oliviertassinari what do you think? |
Member
|
@mnajdova Sounds great. In the end, I believe we will get most of the readers on Medium, they won't see the style of the table (as far as I know, Medium will override it), so feel free to iterate as you see fit 👌. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blog post page - https://deploy-preview-21555--material-ui.netlify.app/blog/2020-developer-survey-results/