-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Allow linking icons state in the URL #25053
Comments
We have explored supporting the open search API in #16764. I don't think that we should do anything special for the icons. It leads me to open algolia/docsearch#769. |
Sorry I didn't find that issue in my search. When I say "search engine shortcut" I'm referring to the search parameter in the url not to the OpenSearch support. This means that the only change on the MUI docs would be to look for the URL in the parameter on component load and, if it is present, set it as value of the search text field. The actual visible change is when using the the URL bar in Chrome. I believe this could be useful for some, but most importantly:
I proposed it only for the icon page because I believe it is the only one where it could be actually useful, since people who use MUI will probably visit it frequently and to me it seems that the icons are not indexed with Algolia (but I could be wrong) |
@GabriFila Oh ok, I didn't understand your request correctly then. So you want to reproduce what https://material.io/resources/icons/ supports. 💯 for allowing to link specific icons, search, and variants with coworkers and self. I recall mentioning it with @DanailH. |
Yes, I meant something like that 😍, could I get assigned to this issue and make a PR to add it? Sorry, I don't know if there are specific procedures and/or requirements. |
@GabriFila Prefect, feel free to solve this pain :) |
The pain was also raised in mui/mui-x#1030 (comment) too :) |
Summary 💡
Allow reaching the MUI icon picker with the search parameter already set through chrome search engine shortcuts.
Examples 🌈
A working and useful example can be found here where you can use the shortcut to quickly access the dictionary translation of a word.
Motivation 🔦
I use a lot this library and its icons, and every time I want to search for an icon I need to search in google, then click on the page link and type the search. I know it may sound unnecessary but I believe it could be appealing and useful to some people. I would also like to work on it
Thank you
The text was updated successfully, but these errors were encountered: