Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Remove the mockPortal workaround #10208

Merged
merged 1 commit into from
Feb 7, 2018
Merged

[test] Remove the mockPortal workaround #10208

merged 1 commit into from
Feb 7, 2018

Conversation

leMaik
Copy link
Member

@leMaik leMaik commented Feb 7, 2018

Enzyme added support for portals in enzyme-adapter-react-16 v1.1.0, so the mockPortal hack can be removed now. 🎉

@leMaik leMaik added the test label Feb 7, 2018
oliviertassinari
oliviertassinari approved these changes Feb 7, 2018
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@leMaik leMaik merged commit aa10940 into mui:v1-beta Feb 7, 2018
@leMaik leMaik deleted the drop-portal-hack branch February 7, 2018 22:13
@oliviertassinari oliviertassinari mentioned this pull request Apr 20, 2018
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leMaik @oliviertassinari