Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs] Fix TabIndicatorProps merge #11494

Merged
merged 3 commits into from
May 20, 2018
Merged

[Tabs] Fix TabIndicatorProps merge #11494

merged 3 commits into from
May 20, 2018

Conversation

adeelibr
Copy link
Contributor

@adeelibr adeelibr commented May 19, 2018 •
edited by oliviertassinari
Loading

Closes #11085

@adeelibr adeelibr mentioned this pull request May 19, 2018
Closed
@oliviertassinari oliviertassinari changed the title Added TabIndicatorStyle property in TabIndicator to modofy/overrite i… [Tabs] Fix TabIndicatorProps merge May 19, 2018
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: tabs This is the name of the generic UI component, not the React module! labels May 19, 2018
adeelibr
adeelibr commented May 19, 2018
View reviewed changes
Copy link
Contributor Author

@adeelibr adeelibr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 understood your approach for this, makes more sense. I'll try to do a better job next time.

@oliviertassinari oliviertassinari merged commit 97c3a92 into mui:master May 20, 2018
@oliviertassinari
Copy link
Member

Thanks

@adeelibr adeelibr deleted the tab-indicator-style branch May 30, 2019 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: tabs This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adeelibr @oliviertassinari