Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Use Chrome Headless for the tests over PhantomJS #11961

Merged
merged 1 commit into from
Jun 24, 2018
Merged

[core] Use Chrome Headless for the tests over PhantomJS #11961

merged 1 commit into from
Jun 24, 2018

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jun 24, 2018 •
edited
Loading

PhantomJS is:

  • No longer maintained
  • ⚠️ Requiring us to use a polyfill, very dangerous as we might break older browser compatibility without noticing.
  • Prevent us from upgrading Sinon

So it's out 💥

@oliviertassinari oliviertassinari force-pushed the chrome-headless branch 3 times, most recently from 750f98a to 88bf13e Compare June 24, 2018 10:51
@oliviertassinari oliviertassinari self-assigned this Jun 24, 2018
@oliviertassinari oliviertassinari merged commit 4ca0b17 into mui:master Jun 24, 2018
@oliviertassinari oliviertassinari deleted the chrome-headless branch June 24, 2018 11:26
acroyear pushed a commit to acroyear/material-ui that referenced this pull request Jul 14, 2018
@oliviertassinari
[core] Use Chrome Headless for the tests over PhantomJS (mui#11961)
0c3d829
@snyk-bot snyk-bot mentioned this pull request Sep 30, 2019
Open
This was referenced Mar 26, 2020
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oliviertassinari oliviertassinari

Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oliviertassinari