[core] Remove usage of theme.spacing.unit #12022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
remove-theme-spacing-unit
branch
2 times, most recently
from
e248ef7
to
254208a
Compare
oliviertassinari
force-pushed
the
remove-theme-spacing-unit
branch
from
254208a
to
56be16b
Compare
mbrookes
reviewed
Jul 1, 2018
| @@ -83,11 +83,11 @@ const styles = theme => ({ | |||
| fontSize: 16, | |||
| color: theme.palette.text.primary, | |||
| '& .anchor-link': { | |||
| marginTop: -theme.spacing.unit * 12, // Offset for the anchor. | |||
| marginTop: -8 * 12, // Offset for the anchor. | |||
There was a problem hiding this comment.
Even though it's a bit more work, I would just make this -96, and so on.
oliviertassinari
force-pushed
the
remove-theme-spacing-unit
branch
from
56be16b
to
155b7ab
Compare
|
So you encourage people to not use |
|
@vuhrmeister No, by keeping it in the demos, we are still encouraging people to use it. I'm using it everywhere too on the product I'm working on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change comes from an internal discussion with @mbrookes. The usage of
theme.spacing.unitwas only here to illustrate the link with the 8dp spacing unit. In practice, we do not expect people to change the value. By doing this change, we make the style generation lighter (-0.3 Kb gzipped).P.S. I have only changed the source code, not the demos.
P.S. I wish we had a performance benchmark to see the implications of such change.