[TableSortLabel] Support custom icon component #12630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chill-cod3r
changed the title
chill-cod3r
changed the title
added 4 commits
August 23, 2018 23:23
oliviertassinari
added
new feature
oliviertassinari
changed the title
|
@wolfejw86 It's a great first pull request on Material-UI 👌🏻. Thank you for giving it a shot! |
|
oh nice! just got a chance to check this today. just the period at the end eh? ha! Thanks. glad to be able to contribute to one of my favorite ui frameworks! |
marcelpanse
pushed a commit
to marcelpanse/material-ui
that referenced
this pull request
Oct 2, 2018
* adding custom IconComponent prop to TableSortLabel, test for presence, and ts type * run prettier * rebuilt docs api * cleanup * let's merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding custom IconComponent prop to TableSortLabel, test for presence…and ts type
Closes #12618