Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slider] Add missing thumb TypeScript definition #13650

Merged
merged 3 commits into from
Nov 20, 2018
Merged

[Slider] Add missing thumb TypeScript definition #13650

merged 3 commits into from
Nov 20, 2018

Conversation

dhiroll
Copy link
Contributor

@dhiroll dhiroll commented Nov 20, 2018 •
edited by oliviertassinari
Loading

@oliviertassinari

I have added thumb?: React.ReactElement; to the interface of Sliderprops

File : packages/material-ui-lab/src/Slider/Slider.d.ts

Closes #13636

@oliviertassinari oliviertassinari changed the title Update Slider.d.ts [Slider] Add missing thumb TypeScript definition Nov 20, 2018
@oliviertassinari oliviertassinari added the component: slider This is the name of the generic UI component, not the React module! label Nov 20, 2018
@oliviertassinari oliviertassinari merged commit 60a3549 into mui:master Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhiroll @oliviertassinari @eps1lon