[docs] Add keyframes in the v3 -> v4 upgrade guide #15039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,7 +29,7 @@ function SwipeableTemporaryDrawer() { | |||
| }); | |||
|
|
|||
| const toggleDrawer = (side, open) => event => { | |||
| if (event.type === 'keydown' && (event.key === 'Tab' || event.key === 'Shift')) { | |||
| if (event && event.type === 'keydown' && (event.key === 'Tab' || event.key === 'Shift')) { | |||
There was a problem hiding this comment.
Broken swipe demo
| @@ -8,7 +8,7 @@ Feel free to submit a pull request to add more projects; we will accept them if | |||
|
|
|||
| ## Design resources | |||
|
|
|||
| - [Figma UI Kit](https://dribbble.com/shots/6164699-Material-UI-React-components-in-Figma-Free-Download#shot-description) for Material-UI. | |||
| - [Figma UI Kit](https://material.5ly.co/) for Material-UI. | |||
| @@ -40,7 +40,7 @@ class MyDocument extends Document { | |||
| } | |||
|
|
|||
| return ( | |||
| <html lang="en" dir="ltr"> | |||
| <html lang={userLanguage} dir="ltr"> | |||
oliviertassinari
force-pushed
the
docs-break-change
branch
2 times, most recently
from
cf61a58
to
9951759
Compare
oliviertassinari
force-pushed
the
docs-break-change
branch
from
9951759
to
d470ba0
Compare
| @@ -326,6 +326,11 @@ const Button = styled(styles, { name: 'button' })(ButtonBase); | |||
| const Button = withStyles(styles, { name: 'button' })(ButtonBase); | |||
| ``` | |||
|
|
|||
| ## CSS prefixes | |||
There was a problem hiding this comment.
To clear people mind.
|
No bundle size changes comparing ae31efe...d470ba0 |
joshwooding
approved these changes
Mar 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's related to #14763.
Bonus, I have incorporated a few small changes.