Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Divider] Enable component generic props #15040

Merged
merged 7 commits into from Mar 25, 2019
Merged

[Divider] Enable component generic props #15040

merged 7 commits into from Mar 25, 2019

Conversation

StevenGodin
Copy link
Contributor

contributes to #14897

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 25, 2019 •
edited

No bundle size changes comparing 0c0f9b1...698c81d

Generated by 🚫 dangerJS against 698c81d

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: divider This is the name of the generic UI component, not the React module! typescript labels Mar 25, 2019
@oliviertassinari oliviertassinari mentioned this pull request Mar 25, 2019
Merged
1 task
@eps1lon eps1lon changed the title [docs] Add TypeScript demos for Dividers, change Divider to OverridableComponent [Divider] Enable component generic props Mar 25, 2019
@oliviertassinari
Copy link
Member

@StevenGodin I have rebased your pull request on the next branch, we gonna focus on the broken divider TypeScript definition is you don't mind :)

@oliviertassinari oliviertassinari merged commit 60e0c31 into mui:next Mar 25, 2019
@oliviertassinari
Copy link
Member

@StevenGodin It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

@oliviertassinari oliviertassinari mentioned this pull request Mar 25, 2019
Merged
1 task
@joshwooding joshwooding mentioned this pull request Apr 19, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: divider This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@StevenGodin @mui-pr-bot @oliviertassinari