Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breadcrumbs] Fix types and enable component generic props #15414

Merged
merged 2 commits into from Apr 19, 2019
Merged

[Breadcrumbs] Fix types and enable component generic props #15414

merged 2 commits into from Apr 19, 2019

Conversation

Atralbus
Copy link
Contributor

Fixes #15413

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 19, 2019 •
edited

No bundle size changes comparing 1bff0f7...29d234a

Generated by 🚫 dangerJS against 29d234a

@oliviertassinari oliviertassinari added component: breadcrumbs This is the name of the generic UI component, not the React module! typescript labels Apr 19, 2019
@joshwooding
Copy link
Member

joshwooding commented Apr 19, 2019 •
edited

Nice, spot! Do you want to apply #15040 to this as well?

@oliviertassinari oliviertassinari changed the title [Breadcrumbs] Fix types for props [Breadcrumbs] Fix types for itemsAfterCollapse and itemsBeforeCollapse Apr 19, 2019
@Atralbus
Copy link
Contributor Author

Atralbus commented Apr 19, 2019 •
edited

@joshwooding I added generic props to this branch, should I have opened a separate branch for that?

@joshwooding
Copy link
Member

@joshwooding I added generic props to this branch, should I have opened a separate branch for that?

@Atralbus Applying it here is fine. Thank you :)

@joshwooding joshwooding changed the title [Breadcrumbs] Fix types for itemsAfterCollapse and itemsBeforeCollapse [Breadcrumbs] Fix types and enable component generic props Apr 19, 2019
@oliviertassinari oliviertassinari merged commit bebd52a into mui:next Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@joshwooding joshwooding joshwooding approved these changes

Assignees
No one assigned
Labels
component: breadcrumbs This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breadcrumbs contains wrong types for props
4 participants
@Atralbus @mui-pr-bot @joshwooding @oliviertassinari