Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Migrate docs' badge page to hooks #15109

Merged
merged 6 commits into from
Mar 30, 2019
Merged

[docs] Migrate docs' badge page to hooks #15109

merged 6 commits into from
Mar 30, 2019

Conversation

apanizo
Copy link
Contributor

@apanizo apanizo commented Mar 29, 2019 •
edited
Loading

Description
This PR migrates the doc's badge page to hooks. Relates to #15032.

@apanizo apanizo changed the title [docs] - Migrate docs' badge page to hooks [docs] Migrate docs' badge page to hooks Mar 29, 2019
@mui-pr-bot
Copy link

No bundle size changes comparing 264c64d...241e1cf

Generated by 🚫 dangerJS against 241e1cf

@apanizo
Copy link
Contributor Author

apanizo commented Mar 29, 2019

Interesting.

After running yarn start I compared the GridList page against the local one and they seem to be similar... 🤔

How can I debug the Argos error?

@joshwooding
Copy link
Member

@apanizo It’s a know problem and is being looked at 😅 I’ve accepted the “difference”. Thanks for your hard work!

@apanizo
Copy link
Contributor Author

apanizo commented Mar 29, 2019

@joshwooding Thanks for getting back to me.

I am really interested in integrating argos in my company's projects, so, if you can share some details about how to debug or approach to solve this issue (or how I can help?!?), they would be much appreciated.

Thanks!!

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Mar 29, 2019
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 29, 2019 •
edited
Loading

@apanizo Thank you for working on this :). It's definitely a win:

Capture d’écran 2019-03-29 à 17 26 52

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 29, 2019 •
edited
Loading

Regarding the visual regression issue. It's a flakiness issue. It has started after with the componentDidMount -> React.useEffect migration of the component. The APIs are not strictly equivalent. Our visual screenshot generation tool should probably wait for the end of the side effects.

@oliviertassinari oliviertassinari merged commit e1b79e0 into mui:next Mar 30, 2019
@oliviertassinari
Copy link
Member

@apanizo Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apanizo @mui-pr-bot @joshwooding @oliviertassinari