Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add ref vs dom node prop explanation #15458

Merged
merged 3 commits into from
Apr 25, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Apr 23, 2019

@eps1lon eps1lon added the docs Improvements or additions to the documentation label Apr 23, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 23, 2019

No bundle size changes comparing 387b79e...13ce60c

Generated by 🚫 dangerJS against 13ce60c

Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that I fully understood the intent of the original text, so my suggestions may not make sense.

docs/src/pages/getting-started/faq/faq.md Outdated Show resolved Hide resolved
docs/src/pages/getting-started/faq/faq.md Show resolved Hide resolved
docs/src/pages/getting-started/faq/faq.md Outdated Show resolved Hide resolved
Co-Authored-By: eps1lon <silbermann.sebastian@gmail.com>
@eps1lon eps1lon self-assigned this Apr 25, 2019
@eps1lon eps1lon requested a review from mbrookes April 25, 2019 10:24
@oliviertassinari oliviertassinari merged commit 64fe6df into mui:next Apr 25, 2019
@eps1lon eps1lon deleted the docs/ref-faq branch April 25, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Portal breaks when using createRef
4 participants