Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix some apostrophe in TypeScript doc #15757

Merged
merged 1 commit into from May 20, 2019
Merged

[docs] Fix some apostrophe in TypeScript doc #15757

merged 1 commit into from May 20, 2019

Conversation

DDDDDanica
Copy link
Member

@DDDDDanica DDDDDanica commented May 20, 2019 •
edited

@DDDDDanica DDDDDanica changed the title fix(doc): fix some apostrophe in typescript doc [docs]: fix some apostrophe in typescript doc May 20, 2019
@DDDDDanica DDDDDanica changed the title [docs]: fix some apostrophe in typescript doc [docs]fix some apostrophe in typescript doc May 20, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented May 20, 2019 •
edited

No bundle size changes comparing 6b73158...240e683

Generated by 🚫 dangerJS against 240e683

@eps1lon
Copy link
Member

eps1lon commented May 20, 2019

The -es.md suffix indicates that this is used for the translated version. It's simply missing a translation. Please see #15754 (comment) and either change the original typescript.md or file an issue in crowdin.

@DDDDDanica
Copy link
Member Author

@eps1lon Thanks. Sorry was editing the wrong file. Pushed my changes now :)

@eps1lon eps1lon added the docs Improvements or additions to the documentation label May 20, 2019
@eps1lon
Copy link
Member

eps1lon commented May 20, 2019

Please remove the changes to the -es.md file.

@DDDDDanica
Copy link
Member Author

Please remove the changes to the -es.md file.

Thanks. done~

@oliviertassinari oliviertassinari changed the title [docs]fix some apostrophe in typescript doc [docs] Fix some apostrophe in TypeScript doc May 20, 2019
@oliviertassinari oliviertassinari merged commit 0b10f8d into mui:next May 20, 2019
@DDDDDanica DDDDDanica deleted the fix/doc-typescript branch May 22, 2019 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DDDDDanica @mui-pr-bot @eps1lon @oliviertassinari