-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs]: fix some typo in typescript doc #15754
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No bundle size changes comparing d598290...9e286b8 |
Much appreciated but since this targets translated versions only it has to filed via https://crowdin.com/project/material-ui-docs |
@eps1lon There're some typo in the origin doc in English that's where I made the changes :) Hope it makes sense. |
* Fix classname for Fab button. * fix the order
* [useScrollTrigger] Enhance trigger, fix/add tests. * [useScrollTrigger] Prevent undefined values * fork when previous is not defined * Simplify trigger, add test * revise logic for initialState and undefined * simplify tests * filter some tests * fix test * One more test * simplify the tests * exclusive threshold
* [docs] Remove empty demo * [docs] Import from package instead of path * [docs] Remove eslint disable annotations in CustomizedTooltip * [docs] Follow pref-spread rule recommendation * [docs] Add propTypes to IntegrationReactSelect * [docs] Remove eslint-disable in ReactVirtualized * [docs] Allow alert in component demos * [docs] Disable jsx-handler names
* Remove react-event-listener from ClickAwayListener * Remove react-event-listener from Snackbar * docs * IE11 hi-jinks Co-Authored-By: Sebastian Silbermann <silbermann.sebastian@gmail.com> * code review * api docs * eslint consistent return * return undefined
* [core] forward ref for icons * [core] Remove memo display name wrapper * Fix tests * Restore Icon displayName suffix
* [docs] Use pickers from material-ui namespace * Fix picker types
* Initial commit * remove 'should check if' tests * test remove unwrap * remove withFormControlContext * Remove muiFormControlRef
* [Popups] Allow Element as anchor el * Fix case sensitive import problem * Revert "Fix case sensitive import problem" This reverts commit b8b71bc. Local failure was due to linked package
* [Portal] Fix disablePortal not working (Fixes #15612) * improve the tests * Remove StrictModeViolation * Sebastian review, remove redundant test * Update StrictModeViolation annotations concerning Portal
* Add strict: true to remaining tests * [Badge] Remove redundant className test Already tested in describeConformance * [Breadcrumbs] Fix test strictMode renders twice * [Transition] Not StrictMode ready * [MobileStepper] Fix tests Some tests were redundant Some used text() which uses findDOMNode * Tooltip no longer uses RootRef
* [docs] Fix linking issues * Fix broken CSS class name * backtick doesn't work in the description * Fix SEO issues * [docs] Add PersistScroll component * fix 300 redirections * fix warning * sebastian review
* [docs] Add greenlink to showcase * Update description and bypass signup link * [docs] Add showcase criteria
#15712) * [test] Colocate shadow root test for focus visible with implementation * [test] Allow yarn test:karma --watch
* [docs] Parse StrictMode readyness from describeConformance * Allow undefined options * Reduce whitespace * [docs] Add StrictMode notes * Link to strictmode section in reactjs docs
* Added CReMa to the related projects CReMa: A boilerplate for web and mobile built on top of Cordova, React and Material-ui. * [docs] Simplify /related-projects * better wording
* [docs] Add developer survey results blog post (#14909) * [docs] Fix internal links in the developer survey (#14922) ...and take advantage of the PR to add some additional commentary. * grammar fix (#14960) * [blog] Add /march-2019-update (#15207) * improve the blog posts * [blog] April 2019 Update (#15617) * [docs] Enable the controls for the blog post * Make blog bloggy * Apply Olivier's diff * give up on a custom font so we can merge * change the font
* [Tab]s Update onChange signature to match docs Changed the value from any to number to match the documentation at https://material-ui.com/api/tabs/ * Sebastian review
* [docs] Enable ripple for AppDrawerNavItem anchors * [docs] Warn about ButtonBase#disableRipple and a11y
* default prop mouseEvent changed to onClick * Snackbar test and ClickAwayListener test
* [docs] Move CodeFund from 10% to 20% * keep track of ClickAwayListener * add focus style to the demo * [docs] Fix Algolia top level duplication * update the readme to report the size * revert bundle tracking
* [docs] Overhaul bundle size guide * Remove evergreen target hint because it might be misleading * fix markdown format * Update docs/src/pages/guides/minimizing-bundle-size/minimizing-bundle-size.md Co-Authored-By: Matt <github@nospam.33m.co> * Update docs/src/pages/guides/minimizing-bundle-size/minimizing-bundle-size.md Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
* [ButtonBase] Convert to function component * Fix focusVisible tests * Fix Tests * Revert wrong node tests * Fix useLayoutEffect warnings * Fix browser tests * Apply suggestions from code review Co-Authored-By: Olivier Tassinari <olivier.tassinari@gmail.com> * consistent rippleRef.current access * Move default props resolution into render * Fix handleServer return type * useEffect -> useImperativeHandle * Remove server branch for useRippleHandler * Move useEnhancedEffect outside of scope Makes it actually invariant once loaded * <> -> <React.Fragment>
* [SpeedDial] Convert to function component * Move default props resolution * Run prettier * yarn docs:api
Need to work on conflicts so might as well start a new PR. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.