Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Portal] Synchronously call onRendered #15943

Merged
merged 1 commit into from
May 30, 2019
Merged

[Portal] Synchronously call onRendered #15943

merged 1 commit into from
May 30, 2019

Conversation

Arlevoy
Copy link
Contributor

@Arlevoy Arlevoy commented May 29, 2019 •
edited by oliviertassinari
Loading

Closes #15906

@Arlevoy Arlevoy mentioned this pull request May 29, 2019
Closed
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: Portal The React component. labels May 29, 2019
@mui-pr-bot
Copy link

Details of bundle changes.

Comparing: 831c6cc...7dc7f6f

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core -0.00% 0.00% 315,057 315,045 86,304 86,306
@material-ui/core/Paper 0.00% 0.00% 67,921 67,921 20,184 20,184
@material-ui/core/Paper.esm 0.00% 0.00% 61,217 61,217 18,981 18,981
@material-ui/core/Popper -0.04% 0.00% 28,740 28,728 10,345 10,345
@material-ui/core/Textarea 0.00% 0.00% 5,513 5,513 2,376 2,376
@material-ui/core/TrapFocus 0.00% 0.00% 3,744 3,744 1,573 1,573
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 15,978 15,978 5,787 5,787
@material-ui/core/useMediaQuery 0.00% 0.00% 2,106 2,106 975 975
@material-ui/lab -0.01% 0.00% 138,866 138,854 42,660 42,662
@material-ui/styles 0.00% 0.00% 51,386 51,386 15,193 15,193
@material-ui/system 0.00% 0.00% 14,463 14,463 4,181 4,181
Button 0.00% 0.00% 83,901 83,901 25,459 25,459
Modal -0.06% 0.00% 20,343 20,331 6,685 6,685
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 55,977 55,977 14,042 14,042
docs.main -0.00% 0.00% 648,947 648,929 204,664 204,667
packages/material-ui/build/umd/material-ui.production.min.js -0.00% -0.00% 293,979 293,970 83,766 83,765

Generated by 🚫 dangerJS against 7dc7f6f

@oliviertassinari oliviertassinari changed the title [Portal] Replace React.useEffect with useEnhancedEffect in Portal [Portal] Synchronously call onRendered May 30, 2019
@oliviertassinari oliviertassinari merged commit e5371f7 into mui:master May 30, 2019
@oliviertassinari
Copy link
Member

oliviertassinari commented May 30, 2019 •
edited
Loading

@Arlevoy Perfect, thanks for taking the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: Portal The React component.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Popper] Position flicker regression in v4
3 participants
@Arlevoy @mui-pr-bot @oliviertassinari