Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Use immediate export in MenuAppBar.js #16032

Merged
merged 4 commits into from
Jun 3, 2019
Merged

[docs] Use immediate export in MenuAppBar.js #16032

merged 4 commits into from
Jun 3, 2019

Conversation

aditya1906
Copy link
Contributor

@merceyz
Copy link
Member

merceyz commented Jun 3, 2019 •
edited
Loading

Interestingly, VSCode's regex search doesn't find this unless I actually open the file.

Please update the typescript version as well

@mui-pr-bot
Copy link

mui-pr-bot commented Jun 3, 2019 •
edited
Loading

No bundle size changes comparing f4dc7bb...5fe5510

Generated by 🚫 dangerJS against 5fe5510

@aditya1906
Copy link
Contributor Author

Is this okay?

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jun 3, 2019
@oliviertassinari oliviertassinari changed the title [docs] use immediate export in MenuAppBar.js [docs] Use immediate export in MenuAppBar.js Jun 3, 2019
@oliviertassinari oliviertassinari merged commit 9ff7491 into mui:master Jun 3, 2019
@oliviertassinari
Copy link
Member

@aditya1906 Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aditya1906 @merceyz @mui-pr-bot @oliviertassinari