Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TreeView] Support node label #17080

Merged
merged 4 commits into from
Aug 22, 2019
Merged

[TreeView] Support node label #17080

merged 4 commits into from
Aug 22, 2019

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 20, 2019 •
edited
Loading

Closes #16997

Capture d’écran 2019-08-21 à 01 28 19

Copy & paste from Gmail

Regarding concurrent mode support, I think that we can wait for it to be an issue, one step at the time.

@oliviertassinari oliviertassinari added new feature New feature or request component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! labels Aug 20, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 20, 2019 •
edited
Loading

Details of bundle changes.

Comparing: aa4e2db...c4aede7

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 329,374 329,374 89,969 89,969
@material-ui/core/Paper 0.00% 0.00% 68,774 68,774 20,490 20,490
@material-ui/core/Paper.esm 0.00% 0.00% 62,148 62,148 19,216 19,216
@material-ui/core/Popper 0.00% 0.00% 28,468 28,468 10,177 10,177
@material-ui/core/Textarea 0.00% 0.00% 5,094 5,094 2,137 2,137
@material-ui/core/TrapFocus 0.00% 0.00% 3,834 3,834 1,614 1,614
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,386 16,386 5,829 5,829
@material-ui/core/useMediaQuery 0.00% 0.00% 2,541 2,541 1,058 1,058
@material-ui/lab +0.05% 🔺 +0.06% 🔺 153,227 153,301 46,689 46,715
@material-ui/styles 0.00% 0.00% 51,492 51,492 15,305 15,305
@material-ui/system 0.00% 0.00% 15,658 15,658 4,361 4,361
Button 0.00% 0.00% 78,778 78,778 24,065 24,065
Modal 0.00% 0.00% 14,346 14,346 5,010 5,010
Portal 0.00% 0.00% 2,907 2,907 1,319 1,319
Rating 0.00% 0.00% 70,245 70,245 21,941 21,941
Slider 0.00% 0.00% 74,470 74,470 23,058 23,058
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 53,510 53,510 13,855 13,855
docs.main 0.00% 0.00% 597,182 597,182 190,717 190,717
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 300,298 300,298 86,412 86,412

Generated by 🚫 dangerJS against c4aede7

oliviertassinari and others added 2 commits August 21, 2019 12:09
@oliviertassinari @mbrookes
Update docs/src/pages/components/tree-view/tree-view.md
1ed0d20 
Co-Authored-By: Matt <github@nospam.33m.co>
@oliviertassinari @mbrookes
Update docs/src/pages/components/tree-view/tree-view.md
95f7eed 
Co-Authored-By: Matt <github@nospam.33m.co>
joshwooding
joshwooding approved these changes Aug 21, 2019
View reviewed changes
Copy link
Member

@joshwooding joshwooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having a look at this!

@oliviertassinari oliviertassinari merged commit 4f10bf7 into mui:master Aug 22, 2019
@oliviertassinari oliviertassinari deleted the tree-view-node-label branch August 22, 2019 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookes mbrookes mbrookes left review comments

@joshwooding joshwooding joshwooding approved these changes

Assignees
No one assigned
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TreeItem label can't accept a custom node
4 participants
@oliviertassinari @mui-pr-bot @mbrookes @joshwooding