[Menu] Isolate more integration tests #17490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Sep 19, 2019
|
|
||
| expect(getAllByRole('menuitem')[0]).to.have.property('tabIndex', 0); | ||
| expect(getAllByRole('menuitem')[1]).to.have.property('tabIndex', -1); | ||
| expect(getAllByRole('menuitem')[2]).to.have.property('tabIndex', -1); |
There was a problem hiding this comment.
I have some "managed-focus" matcher in mind but want to collect more use cases before abstracting it away.
|
No bundle size changes comparing e48aeba...16cfeaa |
This comment has been minimized.
This comment has been minimized.
eps1lon
changed the title
eps1lon
commented
Sep 19, 2019
| import Menu from '@material-ui/core/Menu'; | ||
| import MenuItem from '@material-ui/core/MenuItem'; | ||
|
|
||
| function NestedMenu(props) { |
There was a problem hiding this comment.
Candidate for improvement. It includes no nested menu as I understand them. There are two sibling menus which is not nesting IMO. Also nitpicking on the fact that the "second-menu" is the first in the tree 😄
We probably want to replace this with a test for a cascading menu when we work on #11723
oliviertassinari
approved these changes
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking from #17394 before I'm confident in fixing #16644
This removes commit counting. This is a concern for benchmarks. I have some ideas how we can integrate this smoothly into the test suite but this requires additional work (mostly isolation and if it's possible then only for testing-library tests)