[Chip] Fix Avatar CSS issue #18156
Merged
[Chip] Fix Avatar CSS issue #18156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
the
component: chip
Details of bundle changes.Comparing: 8a78af8...6e01dee
|
NMinhNguyen
reviewed
Nov 3, 2019
| @@ -8,7 +8,6 @@ import useForkRef from '../utils/useForkRef'; | |||
| import unsupportedProp from '../utils/unsupportedProp'; | |||
| import capitalize from '../utils/capitalize'; | |||
| import ButtonBase from '../ButtonBase'; | |||
| import '../Avatar'; // So we don't have any override priority issue. | |||
There was a problem hiding this comment.
Do you think a "harmless" side-effect such as Avatar.propTypes = Avatar.propTypes (or similar, like Avatar.a = Avatar.a) might suffice? I'm on holiday rn so I don't have much time to look into this issue myself, sorry.
There was a problem hiding this comment.
After more reflexion, I think that having to pull out another module to get the correct side effect isn't right. It prevents tree-shaking. Autocomplete users shouldn't bundle the Avatar if they don't use it.
There was a problem hiding this comment.
Enjoy your holidays 👍
NMinhNguyen
reviewed
Nov 3, 2019
| @@ -42,6 +41,29 @@ export const styles = theme => { | |||
| opacity: 0.5, | |||
| pointerEvents: 'none', | |||
| }, | |||
| '& $avatar': { | |||
There was a problem hiding this comment.
I'm curious whether or not you deem this a breaking change because strictly speaking specificity is increased 😅
There was a problem hiding this comment.
The outlined variant already increases the specificity to style the avatar.
There was a problem hiding this comment.
True - but let's say someone was just specifying a single avatar class name, they'd now need to also do & $avatar. Maybe not a big concern - I was more just curious to hear your perspective on breaking/non-breaking changes so we can adopt the same principle at my workplace.
There was a problem hiding this comment.
@NMinhNguyen If somebody has overridden the class, he would likely face #16374, as we do. He would already be forced to increase the specificity.
oliviertassinari
changed the title
NMinhNguyen
reviewed
Nov 3, 2019
Co-Authored-By: Minh Nguyen <minhnguyenxx@gmail.com>
NMinhNguyen
approved these changes
Nov 3, 2019
This was referenced Nov 6, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16374.
Our documentation reproduces the problem, we can verify the fix directly with the Netlify preview.