[Select] Apply disabled color to the icon #20287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 26f39a8...0e2a8c8 Details of page changes
|
oliviertassinari
added
the
component: select
oliviertassinari
changed the title
oliviertassinari
changed the title
oliviertassinari
approved these changes
Mar 26, 2020
There was a problem hiding this comment.
After more thought, I think that going with a color-based approach would be more consistent.
I have tried to customize the color of the select input, changing the color of the icons didn't feel obvious that it was the expected behavior, plus this screenshot surfaces the consistency potential of using the same colors with the IconButton:
https://material.io/components/text-fields/#anatomy
What do you think?
|
After seeing the final code, I agree this approach is better for readability, on top of the consistency benefits it provides. With the previous approach, there are some mental overhead in understanding why Thank you for helping with the fix 👍 |
|
@HenryLie Thanks! |
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
* [NativeSelect] fix icon color on disabled state * [Autocomplete] unify disabled icon color handling with NativeSelect * [Autocomplete] Handle clear icon for consistency * color instead of opacity? Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
This was referenced Mar 30, 2020
This was referenced Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #19833.
This PR both applies the disabled color to the
Selectelement's icon, and apply the same method toAutocompletefor consistency.I hope it's okay to combine those two changes together in one PR?
One thing I'm not really confident of is re-applying
currentColortodisabledpseudo class, because it looks redundant.Any feedback is appreciated.