-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Select] Focus labelled element on click #20833
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 4bfcbec...eedd415 Details of page changes
|
qkdreyer
commented
Apr 29, 2020
eps1lon
reviewed
Apr 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to attach the event handler via DOM API and not just on the element via onMouseDown
?
eps1lon
previously requested changes
Apr 29, 2020
eps1lon
added
accessibility
a11y
component: select
This is the name of the generic UI component, not the React module!
labels
Apr 29, 2020
eps1lon
reviewed
Apr 29, 2020
oliviertassinari
added
the
PR: needs revision
The pull request can't be merged. More details is available on the code review or fails in the CI
label
Apr 29, 2020
oliviertassinari
changed the title
[FormLabel] Focus labelled element on click
[Select] Focus labelled element on click
Apr 29, 2020
oliviertassinari
removed
the
PR: needs revision
The pull request can't be merged. More details is available on the code review or fails in the CI
label
May 3, 2020
oliviertassinari
force-pushed
the
fix-20818
branch
2 times, most recently
from
May 3, 2020 17:46
e5a0360
to
b3432c7
Compare
oliviertassinari
force-pushed
the
fix-20818
branch
from
May 3, 2020 18:00
ba665ff
to
618d7a7
Compare
oliviertassinari
force-pushed
the
fix-20818
branch
from
May 3, 2020 18:00
618d7a7
to
eedd415
Compare
That’s clever, and since the issue is mainly with the Simple Select component I guess this is better ! |
eps1lon
approved these changes
May 4, 2020
eps1lon
approved these changes
May 4, 2020
@qkdreyer Very nice, thanks! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accessibility
a11y
component: select
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20818