-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Migrate some tests to testing-library #21058
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
[test] Migrate some tests to RTL
[test] Migrate some tests to testing-library
May 16, 2020
Details of bundle changes.Comparing: d8cdd9a...923a90d Details of page changes
|
joshwooding
force-pushed
the
migrate-some-tests
branch
from
May 16, 2020 17:56
4549f86
to
ea69e9f
Compare
I have renamed RTL in the title so people reading the changelog don't get confused with right-to-left |
joshwooding
force-pushed
the
migrate-some-tests
branch
from
May 16, 2020 18:21
ea69e9f
to
b90984e
Compare
joshwooding
force-pushed
the
migrate-some-tests
branch
from
May 17, 2020 17:31
5509ce3
to
dcab13d
Compare
eps1lon
requested changes
May 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Really like to new clarity. One question though.
eps1lon
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating tests is a satisfying task :P