Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MenuItem] Add types for ListItemClasses #21654

Merged
merged 3 commits into from
Jul 2, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jul 2, 2020

Tested by typechecking MenuItem.test. Without the change to MenuItem.d.ts this type check failed.

@eps1lon eps1lon added bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module! typescript labels Jul 2, 2020
@@ -11,7 +11,7 @@
"experimentalDecorators": true,
"baseUrl": "./",
"allowSyntheticDefaultImports": true,
"noErrorTruncation": true,
"noErrorTruncation": false,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hasn't turned out very useful by default. Usually I turn it off.

@mui-pr-bot
Copy link

Details of bundle changes

Generated by 🚫 dangerJS against 9c2d4cd

@eps1lon eps1lon merged commit 65d036e into mui:next Jul 2, 2020
@eps1lon eps1lon deleted the fix/MenuItem/ListItemClasses-types branch July 2, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants