-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Avatar] Avoid use of z-index #21685
[Avatar] Avoid use of z-index #21685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spending time on this :)
- What's the
direction
prop for? I fail to see the use case for it - The incentive for changing the implementation was to remove the usage of z-index that can mess with the stacking context of other elements. Could we remove it?
The direction prop is used for change the stack direction if we want it to stack RTL or LTR. I see you and ZChenzy discuss in #21562. Should we add this feature for AvatarGroup?
Yes, we can. @oliviertassinari |
I don't see why we would want to support it. In any case, it's a different concern to the problem we are trying to solve. Please remove it. We can continue the discussion and evalute if worth adding for a future pull request.
Great, let's do that. |
299263c
to
7651a6f
Compare
7651a6f
to
039bae5
Compare
@nvdai2401 It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
How am I able to tell which release this made it into? |
Closes: #21562