Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Avatar] Avoid use of z-index #21685

Merged

Conversation

nvdai2401
Copy link
Contributor

@nvdai2401 nvdai2401 commented Jul 6, 2020

Closes: #21562

@mui-pr-bot
Copy link

mui-pr-bot commented Jul 6, 2020

Details of bundle changes

Generated by 🚫 dangerJS against 039bae5

@oliviertassinari oliviertassinari changed the title [Avatar Group] Better implementation of Avatar Group [Avatar] Better implementation of Avatar Group Jul 6, 2020
@oliviertassinari oliviertassinari added the component: avatar This is the name of the generic UI component, not the React module! label Jul 6, 2020
@oliviertassinari oliviertassinari changed the title [Avatar] Better implementation of Avatar Group [Avatar] Avoid usage of z-index Jul 6, 2020
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spending time on this :)

  • What's the direction prop for? I fail to see the use case for it
  • The incentive for changing the implementation was to remove the usage of z-index that can mess with the stacking context of other elements. Could we remove it?

@nvdai2401
Copy link
Contributor Author

nvdai2401 commented Jul 7, 2020

What's the direction prop for? I fail to see the use case for it

The direction prop is used for change the stack direction if we want it to stack RTL or LTR. I see you and ZChenzy discuss in #21562. Should we add this feature for AvatarGroup?

The incentive for changing the implementation was to remove the usage of z-index that can mess with the stacking context of other elements. Could we remove it?

Yes, we can. @oliviertassinari

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 7, 2020

The direction prop is used for change the stack direction if we want it to stack RTL or LTR.

I don't see why we would want to support it. In any case, it's a different concern to the problem we are trying to solve. Please remove it. We can continue the discussion and evalute if worth adding for a future pull request.

Yes, we can.

Great, let's do that.

@nvdai2401 nvdai2401 force-pushed the avatargroup-add-direction-row-reverse branch 2 times, most recently from 299263c to 7651a6f Compare July 7, 2020 09:44
@oliviertassinari oliviertassinari force-pushed the avatargroup-add-direction-row-reverse branch from 7651a6f to 039bae5 Compare July 7, 2020 14:38
@oliviertassinari oliviertassinari changed the base branch from master to next July 7, 2020 14:38
@oliviertassinari oliviertassinari removed the request for review from dimitropoulos July 7, 2020 14:41
@oliviertassinari oliviertassinari added the new feature New feature or request label Jul 7, 2020
@oliviertassinari oliviertassinari merged commit 53504a2 into mui:next Jul 8, 2020
@oliviertassinari
Copy link
Member

@nvdai2401 It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

@CWSites
Copy link

CWSites commented Mar 26, 2021

How am I able to tell which release this made it into?

@oliviertassinari
Copy link
Member

@CWSites Check the pull request number (#21685) in the changelog.

@mbrookes mbrookes changed the title [Avatar] Avoid usage of z-index [Avatar] Avoid use of z-index Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: avatar This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better implementation of Avatar Group (remove z-index)
4 participants