-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Batch small changes #22314
Merged
oliviertassinari
merged 14 commits into
mui:next
from
oliviertassinari:batch-small-changes-v28
Aug 24, 2020
Merged
[core] Batch small changes #22314
oliviertassinari
merged 14 commits into
mui:next
from
oliviertassinari:batch-small-changes-v28
Aug 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try `document.querySelector('.109ja448cfod')` it will throw. Discovered in https://github.com/mui-org/material-ui-x/blob/91b05ee8b6cc9fb1beab96187fd4308d4b7b294b/packages/grid/x-grid/src/XGrid.test.tsx#L71
The serial comma (also called the Oxford comma) is the last comma before coordinating conjunction and the final item in a series. Its use is considered a matter of style and is cause for much debate. Many style guides require the serial comma, and a few advise against it. There are times when it must be used to avoid confusion or ambiguity. For the sake of consistency, we recommend always using the serial comma.
I wanted to test the behavior of the theme creator helper. It might be intersting to expose it for developers. There are almost no downsides.
oliviertassinari
added
umbrella
For grouping multiple issues to provide a holistic view
core
Infrastructure work going on behind the scenes
labels
Aug 22, 2020
oliviertassinari
force-pushed
the
batch-small-changes-v28
branch
from
August 22, 2020 16:05
4fca178
to
fcd1545
Compare
eps1lon
previously requested changes
Aug 22, 2020
oliviertassinari
force-pushed
the
batch-small-changes-v28
branch
from
August 23, 2020 11:01
1fd4cd1
to
0f4f4d4
Compare
mbrookes
approved these changes
Aug 23, 2020
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Aug 23, 2020
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Aug 23, 2020
mbrookes
requested changes
Aug 24, 2020
Co-authored-by: Matt <github@nospam.33m.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
document.querySelector('.109ja448cfod')
it will throw.Discovered in https://github.com/mui-org/material-ui-x/blob/91b05ee8b6cc9fb1beab96187fd4308d4b7b294b/packages/grid/x-grid/src/XGrid.test.tsx#L71
[core] Use the same names for the commands 4f8ff2b: I was confused about the renaming happening between the root and docs workspaces.[Tooltip] Improve contrast cdc380e: [docs] Add links in the header #22210 (comment)It might be interesting to expose it to developers.