Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Batch small changes #22314

Merged
merged 14 commits into from Aug 24, 2020

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 22, 2020

  • [test] class names can't start with a digit a076c4b: Try document.querySelector('.109ja448cfod') it will throw.
    Discovered in https://github.com/mui-org/material-ui-x/blob/91b05ee8b6cc9fb1beab96187fd4308d4b7b294b/packages/grid/x-grid/src/XGrid.test.tsx#L71
  • [docs] Sort subheaders ASC e41b125: I searching for the accordion, expecting it to be first in the list. but instead had the place of the previous Expension panel.
  • [core] Convention suffix xIcon c2a03c0:
  • [core] Use the same names for the commands 4f8ff2b: I was confused about the renaming happening between the root and docs workspaces.
  • [Tooltip] Improve contrast cdc380e: [docs] Add links in the header #22210 (comment)
  • [docs] Serial comma e9f428b: The serial comma (also called the Oxford comma) is the last comma before coordinating conjunction and the final item in a series. Its use is considered a matter of style and is cause for much debate. Many style guides require the serial comma, and a few advise against it. There are times when it must be used to avoid confusion or ambiguity. For the sake of consistency, we recommend always using the serial comma.
  • [docs] standalone for consistency 5d8f90b: small typo
  • [docs] Fix one missing property -> prop 5339484: small detail
  • [docs] Expose createMuiTheme too 3a01c22: I wanted to test the behavior of the theme creator helper.
    It might be interesting to expose it to developers.
  • [docs] Include notification in the description c09f43d: to help rank against "react notifications".
  • [Stepper] Remove dead code fcd1545

The serial comma (also called the Oxford comma) is the last comma before coordinating conjunction and the final item in a series. Its use is considered a matter of style and is cause for much debate. Many style guides require the serial comma, and a few advise against it. There are times when it must be used to avoid confusion or ambiguity. For the sake of consistency, we recommend always using the serial comma.
I wanted to test the behavior of the theme creator helper.
It might be intersting to expose it for developers.
There are almost no downsides.
@oliviertassinari oliviertassinari added umbrella For grouping multiple issues to provide a holistic view core Infrastructure work going on behind the scenes labels Aug 22, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 22, 2020

Details of bundle changes

Generated by 🚫 dangerJS against 3909771

package.json Outdated Show resolved Hide resolved
packages/material-ui/src/ListItem/ListItem.spec.tsx Outdated Show resolved Hide resolved
packages/material-ui/src/Tooltip/Tooltip.js Outdated Show resolved Hide resolved
test/utils/describeConformance.js Outdated Show resolved Hide resolved
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 23, 2020
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 23, 2020
Co-authored-by: Matt <github@nospam.33m.co>
@oliviertassinari oliviertassinari merged commit 40ecac1 into mui:next Aug 24, 2020
@oliviertassinari oliviertassinari deleted the batch-small-changes-v28 branch August 24, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes umbrella For grouping multiple issues to provide a holistic view
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants