Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Box] Add types for ref #22925

Closed
wants to merge 0 commits into from
Closed

[Box] Add types for ref #22925

wants to merge 0 commits into from

Conversation

lcswillems
Copy link
Contributor

@lcswillems lcswillems commented Oct 7, 2020 •
edited
Loading

Fixes #17010

@lcswillems lcswillems mentioned this pull request Oct 7, 2020
Closed
@mui-pr-bot
Copy link

No bundle size changes comparing cb6b69b...7afcbb7

Generated by 🚫 dangerJS against 7afcbb7

eps1lon
eps1lon requested changes Oct 7, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Could you rebase this PR (especially after #22876)? yarn workspace docs:typescript should technically fail now.

@eps1lon eps1lon changed the title [Box] Add ref property to Box [Box] Add types for ref Oct 7, 2020
@lcswillems lcswillems closed this Oct 7, 2020
@christopherjbaker
Copy link

Is this going to be fixed in 4.x?

@oliviertassinari
Copy link
Member

@christopherjbaker it's not blocking, so no. You can type it as any until you upgrade to v5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon requested changes

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: Box The React component. typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Box] ref missing in TypeScript definition
5 participants
@lcswillems @mui-pr-bot @christopherjbaker @oliviertassinari @eps1lon