[test] Enable failing unexpected console warn|error in browser tests #23063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 777c1a1...81625e5 |
This reverts commit 5e01b5e.
oliviertassinari
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be safe now that we've dropped Safari < 13. Will start failing the test suite if we go back to Safari 10.
Polyfills root-level hooks for karma-mocha. We use dependency injection for
mochain the browser. Their browser build is not importable and from the issues I looked at in their repo (mochajs/mocha#4278, mochajs/mocha#2448) they insist that this is fine.Examples: