Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Update ssr example to use @material-ui/core@next #23155

Merged
merged 3 commits into from
Oct 20, 2020
Merged

[examples] Update ssr example to use @material-ui/core@next #23155

merged 3 commits into from
Oct 20, 2020

Conversation

mnajdova
Copy link
Member

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 19, 2020 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 455fa39

@mnajdova mnajdova added the docs Improvements or additions to the documentation label Oct 19, 2020
oliviertassinari
oliviertassinari approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We link this example as the "reference implementation" for SSR: https://next.material-ui.com/guides/server-rendering/#référence-implementations. We will want to udpate it.

@mnajdova
Copy link
Member Author

We link this example as the "reference implementation" for SSR: https://next.material-ui.com/guides/server-rendering/#référence-implementations. We will want to udpate it.

Sure, let me update before merging

@mnajdova
Copy link
Member Author

We link this example as the "reference implementation" for SSR: https://next.material-ui.com/guides/server-rendering/#référence-implementations. We will want to udpate it.

Updated @oliviertassinari

oliviertassinari
oliviertassinari approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it will get simpler once we finish the migration :)

@mnajdova mnajdova merged commit 41cd2bc into mui:next Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnajdova @mui-pr-bot @oliviertassinari