Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[example] Explain package choice #23938

Merged
merged 7 commits into from
Dec 11, 2020
Merged

[example] Explain package choice #23938

merged 7 commits into from
Dec 11, 2020

Conversation

mnajdova
Copy link
Member

Closes #23931

@mui-pr-bot
Copy link

mui-pr-bot commented Dec 10, 2020 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 646a7c0

@mnajdova mnajdova mentioned this pull request Dec 10, 2020
Merged
oliviertassinari
oliviertassinari approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made an edit proposal to normalize the wording (simpler to search & replace) otherwise, lookg good

examples/gatsby/README.md Outdated Show resolved Hide resolved
examples/nextjs-with-typescript/README.md Outdated Show resolved Hide resolved
examples/nextjs/README.md Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Dec 10, 2020
mnajdova and others added 3 commits December 10, 2020 17:43
@mnajdova @oliviertassinari
Update examples/gatsby/README.md
f2ab53d 
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@mnajdova @oliviertassinari
Update examples/nextjs-with-typescript/README.md
3797cb9 
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@mnajdova @oliviertassinari
Update examples/nextjs/README.md
a89dc4e 
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@eps1lon eps1lon changed the title [example] Updates on the readme on the example projects [example] Explain package choice Dec 11, 2020
@eps1lon eps1lon merged commit 3828cb9 into mui:next Dec 11, 2020
@mbrookes
Copy link
Member

Merged prematurely. The same description needs to be duplicated to all the examples.

@eps1lon
Copy link
Member

eps1lon commented Dec 11, 2020

Merged prematurely. The same description needs to be duplicated to all the examples.

There were no changes requested.

@vicasas
Copy link
Member

vicasas commented Dec 11, 2020

@eps1lon @oliviertassinari That paragraph I think should have gone in all the README of the examples.

20201211_083634.jpg

@mnajdova
Copy link
Member Author

Opened #23958 as a follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookes mbrookes mbrookes left review comments

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add in the documentation what emotion is used for in the integration with Nextjs
6 participants
@mnajdova @mui-pr-bot @mbrookes @eps1lon @vicasas @oliviertassinari