-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add examples for adding and removing Typography variants #24088
[docs] Add examples for adding and removing Typography variants #24088
Conversation
<Typography variant="h3">h3</Typography>; | ||
``` | ||
|
||
{{"demo": "pages/components/typography/TypographyCustomVariant.js", "hideToolbar": true}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am hiding this example, as adding the ts module augmentation on the example is being applied on all docs. The instructions are added as code snippets above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really wish we could isolate the demos regarding module augmentation. We have a couple of places where we use it or should use it. But since these are applied to all files it's quite problematic.
At least so that the type-checking test suite verifies that the module augmentation is working as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, this is problematic.. This is the second time I am hitting this issue so far :\
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the customization example should go in the typography customization section, and referenced from the component page, not the other way around.
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
👍 I swapped the content of the two pages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
Closes #22257