Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Container] Migrate to emotion #24227

Merged
merged 3 commits into from
Jan 3, 2021
Merged

[Container] Migrate to emotion #24227

merged 3 commits into from
Jan 3, 2021

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jan 2, 2021 •
edited
Loading

I was working on #24095 but need to use the sx prop on a Container.

@oliviertassinari oliviertassinari added the component: Container The React component label Jan 2, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Jan 2, 2021 •
edited
Loading

@material-ui/core: parsed: +0.10% , gzip: +0.12%

Details of bundle changes

Generated by 🚫 dangerJS against 3bf7fe8

@oliviertassinari oliviertassinari force-pushed the container-emotion branch 3 times, most recently from cdfae9b to 22ca03f Compare January 2, 2021 22:08
@oliviertassinari oliviertassinari marked this pull request as ready for review January 2, 2021 22:58
This was referenced Jan 3, 2021
Merged
Merged
Merged
@oliviertassinari oliviertassinari marked this pull request as draft January 3, 2021 11:46
@oliviertassinari oliviertassinari mentioned this pull request Jan 3, 2021
Merged
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 3, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 3, 2021
@oliviertassinari oliviertassinari marked this pull request as ready for review January 3, 2021 21:57
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jan 3, 2021 •
edited
Loading

I have moved all changes unrelated to the strict migration of the Container to emotion to different efforts (PRs). I'm continuously amazed by how we keep discovering improvement opportunities as we migrate more components. We start to be in pretty good shape. It's going smooth :). 30 minutes should be enough to migrate a component like the Container.

mnajdova
mnajdova approved these changes Jan 3, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliviertassinari oliviertassinari merged commit aeee127 into mui:next Jan 3, 2021
@oliviertassinari oliviertassinari deleted the container-emotion branch January 3, 2021 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: Container The React component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliviertassinari @mui-pr-bot @mnajdova