Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Update issue mark duplicate #24311

Merged
merged 2 commits into from
Jan 8, 2021
Merged

[core] Update issue mark duplicate #24311

merged 2 commits into from
Jan 8, 2021

Conversation

xrkffgg
Copy link
Contributor

@xrkffgg xrkffgg commented Jan 8, 2021

#24283 (comment)

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 8, 2021

No bundle size changes

Generated by 🚫 dangerJS against 9a65d01

@eps1lon eps1lon added the core Infrastructure work going on behind the scenes label Jan 8, 2021
@oliviertassinari oliviertassinari merged commit a4b5e55 into mui:next Jan 8, 2021
@oliviertassinari
Copy link
Member

@xrkffgg Thanks for the follow-up, let's give it a try :)

@xrkffgg xrkffgg deleted the patch-1 branch January 8, 2021 12:14
@xrkffgg
Copy link
Contributor Author

xrkffgg commented Jan 8, 2021

Actually, I thought about it again, I don’t need to remove issue-labeled.yml.

Like this #24314

You add the duplicate, not type Duplicate of #xx, it will auto remove this 2 labels.

If you need, you can add it yourself~ 😊

@oliviertassinari
Copy link
Member

@xrkffgg I think that we are good

@oliviertassinari
Copy link
Member

I might have found a new bug. #24365 see how "duplicate" is added and removed at the same time.

@xrkffgg
Copy link
Contributor Author

xrkffgg commented Jan 12, 2021

I think it may happen occasionally because of asynchronous processing or cache.
Don't worry, let me improve it.
This is indeed a deeply hidden problem, and I have not found it after many tests. Thank you for telling me about this bug.

@xrkffgg
Copy link
Contributor Author

xrkffgg commented Jan 12, 2021

After many tests, I also have this phenomenon

image

I think it's probably because of the API

https://docs.github.com/en/free-pro-team@latest/rest/reference/issues#set-labels-for-an-issue

  • Set labels for an issue
    Removes any previous labels and sets the new labels for an issue.

I will circumvent this API and use other perfect functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants