Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Showcase tcespal #24793

Merged
merged 3 commits into from
Feb 7, 2021
Merged

[docs] Showcase tcespal #24793

merged 3 commits into from
Feb 7, 2021

Conversation

0xKheops
Copy link
Contributor

@0xKheops 0xKheops commented Feb 6, 2021

Added my site https://tcespal.com on the showcase page

@mui-pr-bot
Copy link

mui-pr-bot commented Feb 6, 2021 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 0f15d8a

@0xKheops 0xKheops changed the title Showcase tcespal [Showcase] tcespal Feb 6, 2021
@0xKheops 0xKheops changed the title [Showcase] tcespal [docs] Showcase tcespal Feb 6, 2021
@mbrookes
Copy link
Member

mbrookes commented Feb 6, 2021

Meets the 'non-material' eligibility criteria.

Please could you make the image 900 x 675, tweak the jpeg quality to keep the image size under 100KB, and run it through imageoptim or equivalent?

@mbrookes mbrookes added the docs Improvements or additions to the documentation label Feb 6, 2021
@oliviertassinari
Copy link
Member

Please could you make the image 900 x 675,

The latest images have been 1200 x 900 to render well on high resolution screen.

@0xKheops
Copy link
Contributor Author

0xKheops commented Feb 7, 2021

Thanks for pointing this out, I updated the image :)

@mbrookes mbrookes merged commit fd164ef into mui:next Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xKheops @mui-pr-bot @mbrookes @oliviertassinari