Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Make render required with describeConformanceV5 #25003

Merged
merged 5 commits into from
Feb 21, 2021
Merged

[test] Make render required with describeConformanceV5 #25003

merged 5 commits into from
Feb 21, 2021

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Feb 19, 2021 •
edited
Loading

Move the resolution of #24968 (comment) into a different pull request. I have created 3 commits to make the changes easier to review:

  1. The problem
  2. The fix
  3. The cleanup

@oliviertassinari oliviertassinari mentioned this pull request Feb 19, 2021
Merged
1 task
@mui-pr-bot
Copy link

mui-pr-bot commented Feb 19, 2021 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 0fc7764

@eps1lon
Copy link
Member

eps1lon commented Feb 19, 2021

Wouldn't it be better to just re-use the render from the test suite? We're doing the same with mount and it's unclear why we have different approaches for mount and render.

@oliviertassinari
Copy link
Member Author

Wouldn't it be better to just re-use the render from the test suite?

@eps1lon Happy to do this, I have started in this direction in #24968, and just reverted: d7852e0. Should I do it in this PR?

@eps1lon
Copy link
Member

eps1lon commented Feb 19, 2021

Wouldn't it be better to just re-use the render from the test suite?

@eps1lon Happy to do this, I have started in this direction in #24968, and just reverted: d7852e0. Should I do it in this PR?

That'd be awesome. The less (nested) test hooks we have the easier to is to follow their execution timing.

@oliviertassinari oliviertassinari changed the title [test] Show issue with describeConformanceV5 [test] Make render required with describeConformanceV5 Feb 20, 2021
@oliviertassinari oliviertassinari changed the title [test] Make render required with describeConformanceV5 [test] Make render required with describeConformanceV5 Feb 20, 2021
@oliviertassinari
Copy link
Member Author

@eps1lon Done

eps1lon
eps1lon approved these changes Feb 21, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup 👍

@oliviertassinari oliviertassinari merged commit 6b5e1c7 into mui:next Feb 21, 2021
@oliviertassinari oliviertassinari deleted the improve-describeConformanceV5 branch February 21, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliviertassinari @mui-pr-bot @eps1lon