Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accordion] Implement Accordion #25

Open
Tracked by #10
michaldudak opened this issue Jul 19, 2023 · 4 comments · May be fixed by #551
Open
Tracked by #10

[Accordion] Implement Accordion #25

michaldudak opened this issue Jul 19, 2023 · 4 comments · May be fixed by #551
Assignees
@mj12albert
Labels
component: accordion This is the name of the generic UI component, not the React module! new feature New feature or request

Comments

@michaldudak
Copy link
Member

michaldudak commented Jul 19, 2023 •
edited by oliviertassinari

This is the place to gather ideas, measure interest and discuss the API and implementation details of the accordion component and hook.

See #10 for the umbrella issue to track progress on Base UI and mui/material-ui#6218 for the problem this project solve.
@michaldudak michaldudak mentioned this issue Feb 27, 2024
Open
35 tasks
@michaldudak michaldudak changed the title Accordion ⭐ [Accordion][base] Create the unstyled component and hook Jul 19, 2023
@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 14, 2023 •
edited

Material UI id API feels so outdated (e.g. id={summary.props['aria-controls']}) now that we can use the context and useId https://mui.com/material-ui/react-accordion/#basic-accordion

Screenshot 2023-08-15 at 00 52 48

@oliviertassinari oliviertassinari mentioned this issue Aug 14, 2023
Merged
@oliviertassinari
Copy link
Member

To consider what we should do with the arrow key navigation https://www.w3.org/WAI/ARIA/apg/patterns/accordion/#keyboardinteraction. I don't know if we want this, I guess, why not?

@michaldudak michaldudak changed the title [Accordion][base] Create the unstyled component and hook [Accordion][base-ui] Create the unstyled component and hook Aug 18, 2023
@logonoff
Copy link

an idea for the base-ui accordion component is to use the details and summary HTML elements for the component so that the accordion would still work for users who have javascript turned off. i feel like semantically it might also make more sense since its functionality is similar to the accordion component

@michaldudak
Copy link
Member Author

Related issue to take into consideration: mui/material-ui#36297

@michaldudak michaldudak transferred this issue from mui/material-ui Feb 27, 2024
@michaldudak michaldudak changed the title [Accordion][base-ui] Create the unstyled component and hook [Accordion] Create the unstyled component and hook Feb 27, 2024
@michaldudak michaldudak added new feature New feature or request component: accordion This is the name of the generic UI component, not the React module! labels Feb 27, 2024
@colmtuite colmtuite changed the title [Accordion] Create the unstyled component and hook [Accordion] Implement Accordion Mar 21, 2024
@colmtuite colmtuite assigned michaldudak and unassigned michaldudak Mar 21, 2024
@mj12albert mj12albert self-assigned this Jul 10, 2024
@mj12albert mj12albert mentioned this issue Jul 16, 2024
Open
@mj12albert mj12albert linked a pull request Aug 23, 2024 that will close this issue
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mj12albert mj12albert

Labels
component: accordion This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
Base UI Stable v1
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Accordion] New Accordion components and hooks mj12albert/base-ui
4 participants
@oliviertassinari @michaldudak @mj12albert @logonoff