Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Update @mui deps to next #354

Merged
merged 2 commits into from
Apr 25, 2024
Merged

[core] Update @mui deps to next #354

merged 2 commits into from
Apr 25, 2024

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented Apr 24, 2024

Installs currently error due to:

"@mui/docs": "https://pkg.csb.dev/mui/material-ui/commit/19d7243c/@mui/docs"

@atomiks atomiks added the core Infrastructure work going on behind the scenes label Apr 24, 2024
@atomiks
Copy link
Contributor Author

atomiks commented Apr 24, 2024

Not sure what's going on with the lockfile. This is pnpm's own generation, including after --fix-lockfile

docs/package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@michaldudak
Copy link
Member

Not sure what's going on with the lockfile. This is pnpm's own generation, including after --fix-lockfile

Do you have pnpm v9? Your lockfile's version is v6 (which is the format used by pnpm v8).

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 25, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 25, 2024
Fix lockfile

Feedback

Fix lockfile

Dedupe

Merge
@atomiks
Copy link
Contributor Author

atomiks commented Apr 25, 2024

Do you have pnpm v9? Your lockfile's version is v6 (which is the format used by pnpm v8).

I thought I updated to test v9, but it didn't actually update it seems. Updated now and after a few dozen commands it looks like it's finally working :-)

@atomiks atomiks merged commit e0b3699 into mui:master Apr 25, 2024
16 checks passed
@atomiks atomiks deleted the chore/deps branch April 25, 2024 12:19
michaldudak pushed a commit to michaldudak/base-ui that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants