Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Should use pseudo-classes #1845

Closed
oliviertassinari opened this issue May 31, 2020 · 4 comments
Closed

[RFC] Should use pseudo-classes #1845

oliviertassinari opened this issue May 31, 2020 · 4 comments
Labels
breaking change enhancement New feature or request

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented May 31, 2020 •
edited

Material-UI has the concept of pseudo-classes that I believe we could leverage more often in the picker components. The concept is detailed in https://material-ui.com/customization/components/#pseudo-classes, it also comes with an explanation of why and when it can be interesting.

I have founds these potential states we might likely want to refactor to ease customizations:
@oliviertassinari oliviertassinari changed the title [RFC] Consider using pseudo-classes [RFC] Should use pseudo-classes Jun 25, 2020
@oliviertassinari oliviertassinari mentioned this issue Jun 29, 2020
Closed
@dmtrKovalenko
Copy link
Member

dmtrKovalenko commented Jul 3, 2020 •
edited

Which pseudo-class do you propose for selected state? It is not the same as focused

@oliviertassinari
Copy link
Member Author

@dmtrKovalenko We have been using selected so far: https://material-ui.com/customization/components/#pseudo-classes.

@dmtrKovalenko
Copy link
Member

There is no selected pseudo class, as far as I know

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jul 3, 2020 •
edited

The idea would be to create a selected: {} style rule to serve this purpose.

@oliviertassinari oliviertassinari mentioned this issue Jul 8, 2020
Closed
dmtrKovalenko added a commit that referenced this issue Jul 13, 2020
@dmtrKovalenko
Use pseudo-classes for selected and disabled, closes #1845
1e72edf
todor-a pushed a commit to todor-a/material-ui-pickers that referenced this issue Jul 18, 2020
@dmtrKovalenko @oliviertassinari @todor-a
Consolidate classes naming (mui#1950)
baff00a 
* Change component name from MuiPickers to MuiPicker

* Name root classnames "root"

* Use pseudo-classes for disabled styling

* Remove useless yearDisabled class

* Update demo and typescript tests for overrides

* Repalce MuiPicker with MuiPickers

* Consolidate right component display name with mui component name

* Update index.ts reexports to match component display names

* Remove useless parameter

* Fix docs example

* Fix override example tsc

* Use pseudo-classes for selected and disabled, closes mui#1845

* Address PR feedback

* Update lib/src/Picker/Picker.tsx

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

* Update lib/src/views/Clock/Clock.tsx

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

* Make more convenient css classes names

* Remove today border from selected day

* Remove useless comment

* Update tests

* Fix global overrid of Mui-selected and Mui-disabled classes

* Use theme.palette.secondary instead of hint

* Fix linter

* Fix incorrect package prefix

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliviertassinari @dmtrKovalenko