Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] make DateTimePickerValidation example work out of the box #1817

Closed
wants to merge 1 commit into from
Closed

[docs] make DateTimePickerValidation example work out of the box #1817

wants to merge 1 commit into from

Conversation

dandv
Copy link
Contributor

@dandv dandv commented May 25, 2020

That example generates warnings in the CSB console though (#1776).

The mask "//____ : _M" you passed is not valid for the format used P p. Falling down to uncontrolled not-masked input.

image

@vercel
Copy link

vercel bot commented May 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mui-org/material-ui-pickers/if3ofhp9e
✅ Preview: https://material-ui-pickers-git-fork-dandv-patch-3.mui-org.now.sh

@cypress
Copy link

cypress bot commented May 25, 2020



Test summary

77 0 1 0


Run details

Project material-ui-pickers
Status Passed
Commit ac0dbf8
Started May 25, 2020 5:44 AM
Ended May 25, 2020 5:46 AM
Duration 01:39 💡
OS Linux Debian - 9.11
Browser Chrome 78

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@dandv
Copy link
Contributor Author

dandv commented May 25, 2020

Also, I can't select any time - #1818.

@dmtrKovalenko
Copy link
Member

We are not going to add the <LocalizationProvider /> in each demo. At least for now, I think it is only adding white noise to the examples.

@oliviertassinari
Copy link
Member

oliviertassinari commented May 25, 2020

make DateTimePickerValidation example

@dandv We have decided to remove the built-in validation to leave more freedom to users #1730.

That example generates warnings

See #1776.

Also, I can't select any time - #1818.

Perfect, if you could open a new issue for each problem instead of "bundling" them, it would be much better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants