Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TrapFocus import with @material-ui/core v4.10.1 #1857

Merged
merged 4 commits into from Jun 4, 2020

Conversation

dmtrKovalenko
Copy link
Member

This PR closes #1849

@vercel
Copy link

vercel bot commented Jun 4, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mui-org/material-ui-pickers/jfcg5zcpv
✅ Preview: https://material-ui-pickers-git-bugfix-mui-core-4-10.mui-org.now.sh

@dmtrKovalenko dmtrKovalenko changed the title Update to mui-core 4.10 Fix <TrapFocus /> import with @material-ui/core v4.10.1 Jun 4, 2020
@cypress
Copy link

cypress bot commented Jun 4, 2020



Test summary

78 0 1 0


Run details

Project material-ui-pickers
Status Passed
Commit 82b48b1
Started Jun 4, 2020 1:35 PM
Ended Jun 4, 2020 1:36 PM
Duration 01:22 💡
OS Linux Debian - 10.0
Browser Chrome 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should increase the peer-dependency scope too, so that developers get a warning:

https://github.com/mui-org/material-ui-pickers/blob/fb9ca87d0072527ff71ecc9b995c90ea9d633f08/lib/package.json#L34-L35

@oliviertassinari oliviertassinari changed the title Fix <TrapFocus /> import with @material-ui/core v4.10.1 Fix private TrapFocus import with @material-ui/core v4.10.1 Jun 4, 2020
yarn.lock Outdated Show resolved Hide resolved
@dmtrKovalenko dmtrKovalenko changed the title Fix private TrapFocus import with @material-ui/core v4.10.1 Fix TrapFocus import with @material-ui/core v4.10.1 Jun 4, 2020
@dmtrKovalenko dmtrKovalenko merged commit 155de8b into next Jun 4, 2020
@dmtrKovalenko dmtrKovalenko deleted the bugfix/mui-core-4-10 branch June 4, 2020 13:41
@oliviertassinari oliviertassinari added the bug 🐛 Something isn't working label Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incompatible with @material-ui/core": "4.10.1
2 participants