Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#406] [typescript] Make utils prop of MuiPickersUtilsProvider typed … #411

Merged
merged 1 commit into from May 15, 2018

Conversation

dmtrKovalenko
Copy link
Member

  • I have changed my target branch to develop 👊

Closes #406

Description

Do not restrict users on passing typed utils. (Actually this broking types because each utils imports lib-specific types)
In ts its not possible to do typeof Utils<any> microsoft/TypeScript#204

@dmtrKovalenko
Copy link
Member Author

Actually last fix that should come up to rc.9 supported material-ui rc.0

Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not TypeScript folk, but LGTM ;)

@dmtrKovalenko dmtrKovalenko merged commit 52bdd95 into develop May 15, 2018
@cherniavskii cherniavskii deleted the feature/typescript-utils-prop-broken branch May 16, 2018 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants