Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: onMonthChange onYearChange #935

Merged
merged 6 commits into from
Mar 1, 2019

Conversation

dmtrKovalenko
Copy link
Member

This PR closes #875

Description

Adds 2 onMonthChange and onYearChange callbacks

@dmtrKovalenko dmtrKovalenko changed the title Feature/on month change on year change Feature: onMonthChange onYearChange Mar 1, 2019
@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #935 into develop will increase coverage by 0.7%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #935     +/-   ##
==========================================
+ Coverage    92.46%   93.17%   +0.7%     
==========================================
  Files           48       48             
  Lines         1380     1391     +11     
  Branches       124      124             
==========================================
+ Hits          1276     1296     +20     
+ Misses          74       63     -11     
- Partials        30       32      +2
Impacted Files Coverage Δ
lib/src/_shared/DateTextField.tsx 92.78% <ø> (ø) ⬆️
lib/src/DatePicker/DatePickerInline.tsx 100% <100%> (ø) ⬆️
lib/src/DatePicker/components/Calendar.tsx 88.29% <100%> (+10.87%) ⬆️
lib/src/DatePicker/DatePickerModal.tsx 100% <100%> (ø) ⬆️
lib/src/DatePicker/components/CalendarHeader.tsx 94.11% <100%> (+0.17%) ⬆️
lib/src/DateTimePicker/DateTimePickerModal.tsx 100% <100%> (ø) ⬆️
lib/src/DateTimePicker/DateTimePicker.tsx 96.87% <50%> (-1.52%) ⬇️
lib/src/DatePicker/DatePicker.tsx 97.05% <85.71%> (+0.13%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 854c8d4...7c9ba2c. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #935 into develop will increase coverage by 0.7%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #935     +/-   ##
==========================================
+ Coverage    92.46%   93.17%   +0.7%     
==========================================
  Files           48       48             
  Lines         1380     1391     +11     
  Branches       124      124             
==========================================
+ Hits          1276     1296     +20     
+ Misses          74       63     -11     
- Partials        30       32      +2
Impacted Files Coverage Δ
lib/src/_shared/DateTextField.tsx 92.78% <ø> (ø) ⬆️
lib/src/DatePicker/DatePickerInline.tsx 100% <100%> (ø) ⬆️
lib/src/DatePicker/components/Calendar.tsx 88.29% <100%> (+10.87%) ⬆️
lib/src/DatePicker/DatePickerModal.tsx 100% <100%> (ø) ⬆️
lib/src/DatePicker/components/CalendarHeader.tsx 94.11% <100%> (+0.17%) ⬆️
lib/src/DateTimePicker/DateTimePickerModal.tsx 100% <100%> (ø) ⬆️
lib/src/DateTimePicker/DateTimePicker.tsx 96.87% <50%> (-1.52%) ⬇️
lib/src/DatePicker/DatePicker.tsx 97.05% <85.71%> (+0.13%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 854c8d4...7c9ba2c. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #935 into develop will increase coverage by 0.7%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #935     +/-   ##
==========================================
+ Coverage    92.46%   93.17%   +0.7%     
==========================================
  Files           48       48             
  Lines         1380     1391     +11     
  Branches       124      124             
==========================================
+ Hits          1276     1296     +20     
+ Misses          74       63     -11     
- Partials        30       32      +2
Impacted Files Coverage Δ
lib/src/_shared/DateTextField.tsx 92.78% <ø> (ø) ⬆️
lib/src/DatePicker/DatePickerInline.tsx 100% <100%> (ø) ⬆️
lib/src/DatePicker/components/Calendar.tsx 88.29% <100%> (+10.87%) ⬆️
lib/src/DatePicker/DatePickerModal.tsx 100% <100%> (ø) ⬆️
lib/src/DatePicker/components/CalendarHeader.tsx 94.11% <100%> (+0.17%) ⬆️
lib/src/DateTimePicker/DateTimePickerModal.tsx 100% <100%> (ø) ⬆️
lib/src/DateTimePicker/DateTimePicker.tsx 96.87% <50%> (-1.52%) ⬇️
lib/src/DatePicker/DatePicker.tsx 97.05% <85.71%> (+0.13%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 854c8d4...7c9ba2c. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #935 into develop will increase coverage by 0.78%.
The diff coverage is 94.73%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #935      +/-   ##
===========================================
+ Coverage    92.46%   93.24%   +0.78%     
===========================================
  Files           48       48              
  Lines         1380     1392      +12     
  Branches       124      124              
===========================================
+ Hits          1276     1298      +22     
+ Misses          74       62      -12     
- Partials        30       32       +2
Impacted Files Coverage Δ
lib/src/_shared/DateTextField.tsx 92.78% <ø> (ø) ⬆️
lib/src/DateTimePicker/DateTimePicker.tsx 98.43% <100%> (+0.05%) ⬆️
lib/src/DatePicker/components/YearSelection.tsx 92.3% <100%> (+0.2%) ⬆️
lib/src/DatePicker/DatePickerInline.tsx 100% <100%> (ø) ⬆️
lib/src/DatePicker/components/Calendar.tsx 88.29% <100%> (+10.87%) ⬆️
lib/src/DatePicker/DatePickerModal.tsx 100% <100%> (ø) ⬆️
lib/src/DatePicker/components/CalendarHeader.tsx 94.11% <100%> (+0.17%) ⬆️
lib/src/DateTimePicker/DateTimePickerModal.tsx 100% <100%> (ø) ⬆️
lib/src/DatePicker/DatePicker.tsx 97.05% <83.33%> (+0.13%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 854c8d4...9326720. Read the comment docs.

@dmtrKovalenko dmtrKovalenko merged commit 9d11042 into develop Mar 1, 2019
@dmtrKovalenko dmtrKovalenko deleted the feature/onMonthChange-onYearChange branch March 5, 2019 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant