Skip to content

Commit

Permalink
[InputLabel] Add a FormControlClasses property (#8108)
Browse files Browse the repository at this point in the history
  • Loading branch information
oliviertassinari committed Sep 8, 2017
1 parent 277f3e6 commit 621bf6a
Show file tree
Hide file tree
Showing 6 changed files with 27 additions and 15 deletions.
4 changes: 2 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ jobs:
name: Is the size acceptable?
command: yarn size
- run:
name: Can we generate the docs?
command: yarn docs:api && yarn docs:build
name: Can we generate the api of the docs?
command: yarn docs:api
test_browser:
<<: *defaults
steps:
Expand Down
7 changes: 6 additions & 1 deletion src/Input/InputLabel.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ export type Props = {
* If `true`, the label will be displayed in an error state.
*/
error?: boolean,
/**
* `classes` property applied to the `FormControl` element.
*/
FormControlClasses?: Object,
/**
* If `true`, the input of this label is focused.
*/
Expand Down Expand Up @@ -96,6 +100,7 @@ function InputLabel(props: AllProps, context: { muiFormControl: Object }) {
children,
classes,
className: classNameProp,
FormControlClasses,
shrink: shrinkProp,
margin: marginProp,
...other
Expand Down Expand Up @@ -126,7 +131,7 @@ function InputLabel(props: AllProps, context: { muiFormControl: Object }) {
);

return (
<FormLabel className={className} {...other}>
<FormLabel className={className} classes={FormControlClasses} {...other}>
{children}
</FormLabel>
);
Expand Down
7 changes: 7 additions & 0 deletions src/Input/InputLabel.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,13 @@ describe('<InputLabel />', () => {
assert.strictEqual(wrapper.hasClass(classes.disabled), true);
});

describe('props: FormControlClasses', () => {
it('should be able to change the FormLabel style', () => {
const wrapper = shallow(<InputLabel FormControlClasses={{ foo: 'bar' }}>Foo</InputLabel>);
assert.strictEqual(wrapper.props().classes.foo, 'bar');
});
});

describe('with muiFormControl context', () => {
let wrapper;
let muiFormControl;
Expand Down
8 changes: 4 additions & 4 deletions src/Progress/CircularProgress.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,11 @@ function CircularProgress(props) {
const { classes, className, color, size, mode, value, min, max, ...other } = props;
const radius = size / 2;
const rootProps = {};
const svgClasses = classNames(classes.svg, {
const svgClassName = classNames(classes.svg, {
[classes.indeterminateSvg]: mode === 'indeterminate',
});

const circleClasses = classNames(classes.circle, {
const circleClassName = classNames(classes.circle, {
[classes.indeterminateCircle]: mode === 'indeterminate',
[classes.determinateCircle]: mode === 'determinate',
});
Expand All @@ -104,9 +104,9 @@ function CircularProgress(props) {
{...rootProps}
{...other}
>
<svg className={svgClasses} viewBox={`0 0 ${size} ${size}`}>
<svg className={svgClassName} viewBox={`0 0 ${size} ${size}`}>
<circle
className={circleClasses}
className={circleClassName}
style={circleStyle}
cx={radius}
cy={radius}
Expand Down
12 changes: 6 additions & 6 deletions src/Progress/LinearProgress.js
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ function LinearProgress(props) {
[classes.accentDashed]: color === 'accent',
});

const rootClasses = classNames(
const rootClassName = classNames(
classes.root,
{
[classes.primaryColor]: color === 'primary',
Expand All @@ -149,14 +149,14 @@ function LinearProgress(props) {
},
className,
);
const primaryClasses = classNames(classes.bar, {
const primaryClassName = classNames(classes.bar, {
[classes.primaryColorBar]: color === 'primary',
[classes.accentColorBar]: color === 'accent',
[classes.indeterminateBar1]: mode === 'indeterminate' || mode === 'query',
[classes.determinateBar1]: mode === 'determinate',
[classes.bufferBar1]: mode === 'buffer',
});
const secondaryClasses = classNames(classes.bar, {
const secondaryClassName = classNames(classes.bar, {
[classes.bufferBar2]: mode === 'buffer',
[classes.primaryColorBar]: color === 'primary' && mode !== 'buffer',
[classes.primaryColor]: color === 'primary' && mode === 'buffer',
Expand All @@ -176,11 +176,11 @@ function LinearProgress(props) {
}

return (
<div className={rootClasses} {...rootProps} {...other}>
<div className={rootClassName} {...rootProps} {...other}>
{mode === 'buffer' ? <div className={dashedClass} /> : null}
<div className={primaryClasses} style={inlineStyles.primary} />
<div className={primaryClassName} style={inlineStyles.primary} />
{mode === 'determinate' ? null : (
<div className={secondaryClasses} style={inlineStyles.secondary} />
<div className={secondaryClassName} style={inlineStyles.secondary} />
)}
</div>
);
Expand Down
4 changes: 2 additions & 2 deletions src/Table/TableSortLabel.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,14 @@ function TableSortLabel(props) {
classNameProp,
);

const iconClasses = classNames(classes.icon, {
const iconClassName = classNames(classes.icon, {
[classes[direction]]: !!direction,
});

return (
<ButtonBase className={className} component="span" disableRipple {...other}>
{children}
<ArrowDownwardIcon className={iconClasses} />
<ArrowDownwardIcon className={iconClassName} />
</ButtonBase>
);
}
Expand Down

0 comments on commit 621bf6a

Please sign in to comment.